Repository navigation
docs: list implemented GA4GH spec versions - #144
Merged
Merged
Conversation
One row per product with the implemented and the current version of its GA4GH specification, each linked to its source: the spec file on the product's default branch and the upstream release page. Read from the repos: proTES implements TES 1.1.0 (not 1.0), TRS-Filer TRS 2.0.2, Funnel a TES commit after 1.1.0 without a stated release. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Reviewer's GuideDocumentationReplace the per-API summary with product-level implemented and current specification versions, with source links and notes clarifying version discrepancies.
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
uniqueg
marked this pull request as ready for review
November 13, 2026 22:51
Documentation build overview
|
Contributor
Linked issuesChecked at commit b0e744b #143 docs: show implemented GA4GH spec versions · 2 of 3 met · 1 to check by hand
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hey - I've found 2 issues
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location path="docs/partners-and-developers/ga4gh-standards.md" line_range="21" />
<code_context>
+| [Funnel][funnel] | [TES][ga4gh-tes], for tasks | 1.1.0 and later changes: not stated as a release; [its submodule](https://github.com/calypr/funnel/tree/develop/api/tes) points to a commit after 1.1.0 | [1.1.0](https://github.com/ga4gh/task-execution-schemas/releases/tag/v1.1) | [Funnel][funnel] |
</code_context>
<issue_to_address>
**Funnel snapshot cannot be reproduced**
When a reader needs to verify the post-1.1.0 snapshot or Funnel’s develop branch advances, the link to `develop/api/tes` follows a mutable branch, so it no longer identifies the submodule commit used and readers cannot verify the specification snapshot described.
Link to the specific submodule commit instead of the mutable `develop` path.
</issue_to_address>
### Comment 2
<location path="docs/partners-and-developers/ga4gh-standards.md" line_range="17" />
<code_context>
+that the product's default branch builds on, and the release page of the
+specification. Checked in November 2026.
+
+| Product | API | Implemented version | Current version | Docs |
+| --- | --- | --- | --- | --- |
+| [proTES](https://github.com/elixir-cloud-aai/proTES) | [TES][ga4gh-tes], for tasks | [1.1.0](https://github.com/elixir-cloud-aai/proTES/blob/dev/pro_tes/api/20221114.117cd92.task_execution_service.openapi.yaml) | [1.1.0](https://github.com/ga4gh/task-execution-schemas/releases/tag/v1.1) | [proTES](https://protes.readthedocs.io/en/latest/) |
</code_context>
<issue_to_address>
**Poiesis version is omitted**
When a reader considers Poiesis as a Kubernetes TES option, the product table has no Poiesis row, so readers comparing supported Kubernetes TES services cannot find its implemented specification version.
Add Poiesis with its verified implemented version and source, or explicitly state that its version has not been verified and why it is excluded.
</issue_to_address>Sourcery assessment
Approval pending. 2 findings to address first.
Blocking findings: docs/partners-and-developers/ga4gh-standards.md:21, docs/partners-and-developers/ga4gh-standards.md:17
Link Funnel's TES version to the pinned submodule commit instead of the moving develop branch, and add Poiesis, which the operator docs list as a TES service (review by Sourcery). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
uniqueg
commented
Nov 14, 2026
Address the maintainer review: add rows for Conquest (WES 1.1 per its README) and WESkit (WES 1.1.0 spec file), list TRS-Filer as 2.1.0 with a note on ga4gh/tool-registry-service-schemas#295, move the tesk-api link from the table into the TESK note. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the per-API table on the GA4GH Standards page with one row per product (proTES, TESK, Funnel, Poiesis, proWES, Conquest, WESkit, CWL-WES, DRS-Filer, TRS-Filer, Cloud Registry): the implemented version of its GA4GH specification and the current upstream version, each linked to its source (the spec file on the product's default branch, or the spec commit for submodules; the upstream release page).
Facts read from the default branches, not from earlier notes:
117cd92is identical to tagv1.1); the old page said 1.0.tessubmodule atcafac9c, 60 commits behindv1.1).develop): submodule28a83a6, 144 commits afterv1.1; no release stated, noted as such.dev): specc4c17c9, 132 commits afterv1.1; no release stated.master, added on maintainer review): WES 1.1 as stated in its README; no spec file in the repo, noted as such.master, added on maintainer review): WES 1.1.0 (weskit/api/workflow_execution_service_1.1.0.yaml).4854e2f, the release 2.0.2, whose spec states2.1.0; no 2.1.0 release). Per maintainer review, the spec file is the source of truth; the note links Release mismatch 2.0.2 x 2.1.0 ga4gh/tool-registry-service-schemas#295.Light lane: docs-only change; I reviewed the diff myself, no reviewer subagents.
Closes #143
Verification
python scripts/check_names.py: passedmkdocs build --strict: passed, no warningsOpen questions
None.
🤖 Generated with Claude Code